Fix install perms mods and tests to work on MacOSX for real (trilinos/Trilinos#7881) #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Trilinos#7881) In my last set of commits, I was not not able to actaully test this on a MacOSX machine and it needed a few tweaks. I also updated the automated tests for this in TriBITS to 100% pass on MacOSX. Therefore, I am pretty sure this is doing what it is supposed to do. The changes that I had to make were: * The chmod command on MacOSX requires the '-R' argument to be before the permissions change string. (Hopefully Linux/Bash chmod will allow the same also.) * The 'ls' command on MaxOSX formats the ouput a little differently than on Linux/Bash and therefore small changes in the regex matching strings had to be made. (This should work on Linux/Bash as well.)
bartlettroscoe
changed the title
For some reason, the intermediate var STAT_ARGS requires that no space be provided betwee '-c' and '%U'.
bartlettroscoe
changed the title
|
@jmgate and @e10harvey, this makes the install perms fixup support actually work on MaxOSX. (I was finally able to get an account on a MacOSX machine and get this working.) I am going to add the contributions to this PR to the Trilinos PR trilinos/Trilinos#8063. |
bartlettroscoe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Sep 22, 2020
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit 362e27deddda83fb4b2c78b0d32d036da2d93965 Author: Roscoe A. Bartlett <[email protected]> Date: Tue Sep 22 10:09:42 2020 -0600 Summary: Fix stat command args for Linux (#7881) This pulls in updates from the TriBITS PR: * TriBITSPub/TriBITS#329
bartlettroscoe
added a commit
that referenced
this pull request
Sep 22, 2020
…trilinos/Trilinos#7881) Build/Test Cases Summary Enabled Packages: Enabled all Packages 0) MPI_DEBUG => passed: passed=382,notpassed=0 (2.25 min) 1) SERIAL_RELEASE => passed: passed=382,notpassed=0 (1.43 min) 2) MPI_DEBUG_CMake-3.17.0 => passed: passed=387,notpassed=0 (2.85 min) 3) SERIAL_RELEASE_CMake-3.17.0 => passed: passed=387,notpassed=0 (2.40 min) Other local commits for this build/test group: f4001a1, 1ed3811, e8467f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last set of commits in PR #327 (toward trilinos/Trilinos#7881), I was not not able to actually test this on a MacOSX machine and it needed a few tweaks. I also updated the automated tests for this in TriBITS to 100% pass on MacOSX. Therefore, I am pretty sure this is doing what it is supposed to do.
How was this tested?
I ran the TriBITS test suite for serial-debug on a MacOSX machine and they 100% passed showing:
I also ran the TriBITS test suite on my RHEL6 machine 'crf450' and got: